Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIMPLEX Assembly Plus from SpaceDock #10068

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

netkan-bot
Copy link
Member

This pull request was automatically generated by SpaceDock on behalf of theJesuit, to add SIMPLEX Assembly Plus to CKAN.

Please direct questions about this pull request to theJesuit.

Mod details

Key Value
Name SIMPLEX Assembly Plus
Authors theJesuit
Abstract A redistribution of Extraplanetary Launchpads without the bloat
License GPL-3.0
Size 235.70 KiB
Homepage https://forum.kerbalspaceprogram.com/topic/204395-1125-simplex-assembly-12/
Source code <>

Description

Introducing another way of having your Extraplanetary Launchpads and for the Kraken to eat your cake too!

Similar to zer0kerbal's excellent Simple Construction, this mod gives you a low RAM stockish version of Extraplanetary Launchpads, without all the funky looking EL parts.

All parts are included in the SIMPLEX Assembly mod (required).

Stamp-O-Tron Ground anchor now acts as a stock Survey Peg. You can build your rockets/ bases anywhere!

Use the Lab to make your rocketparts, OR, use SIMPLEX Resources to have a two step process to produce your rockets/ craft/

Thanks to taniwha for maintaining the launchpad.dll and Extraplanetary Launchpads
Thanks to zero0Kerbal for some of the MM patch code.

This is an automated commit on behalf of theJesuit
@HebaruSan
Copy link
Member

Also needs the #10099 patch.

@JonnyOThan
Copy link
Contributor

Hey @theJesuit - this mod may cause some issues in the KSP ecosystem as it stands:

  • it contains Launchpad.dll inside AngleCanMods\SIMPLEXAssemblyPlus\Plugins
  • It contains an ExtraplanetaryLaunchpads folder containing some textures

It's unclear from the install instructions whether ExtraplanetaryLaunchpads is a dependency. If it is, then those components of SIMPLEXAssemblyPlus should probably not be installed directly. If it's not, then you should probably move the textures inside your own mod's folder and rename the DLL to something else (ideally SIMPLEXAssemblyPlus because CKAN can only auto-detect installations if the DLL name matches the mod identifier).

apply version tweak
remove AVC clause (it points to EL.version which probably shouldn't be there)
add dependency on SIMPLEXAssembly per spacedock
add install directive
@theJesuit
Copy link

Okay, I have discovered now that I have looked into this, that I don't need the extra Extraplanetary Launchpad folder in Gamedata. Version 1.6.20240725 now fixes this. Thank you for your help!

I don't think I can change the name of the .dll? a number of mods reference launchpad rather than the folder in their MM patching.

I've also updated the Spacedock instructions not to install vanilla Extraplanetary Launchpads and not compatible with SimpleConstruction, and Not So Simplex Construction

@JonnyOThan
Copy link
Contributor

I don't think I can change the name of the .dll? a number of mods reference launchpad rather than the folder in their MM patching.

Is the DLL actually different from the stock EPL one?

@theJesuit
Copy link

I don't think I can change the name of the .dll? a number of mods reference launchpad rather than the folder in their MM patching.

Is the DLL actually different from the stock EPL one?

Nope. Exactly the same.

@JonnyOThan
Copy link
Contributor

JonnyOThan commented Aug 9, 2024

So should this conflict with EPL?

Ah nvm I see the note on spacedock.

@JonnyOThan
Copy link
Contributor

JonnyOThan commented Aug 9, 2024

Are you sure you want all of these patches to potentially activate? And this is not necessarily an exhaustive list.

https://github.com/search?q=%22Needs%5Blaunchpad%5D%22+path%3A*.cfg+NOT+repo%3Ataniwha%2FExtraplanetary-Launchpads&type=code

I think I see a lot of things that will go wrong because the MetalOre resource won't be defined, for example.

@theJesuit
Copy link

I see this as being the most useful comment. I should check here much more often. I'm thinking about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants